gavinchou commented on code in PR #32910: URL: https://github.com/apache/doris/pull/32910#discussion_r1546518062
########## be/src/cloud/cloud_storage_engine.cpp: ########## @@ -136,9 +136,7 @@ Status CloudStorageEngine::open() { LOG(WARNING) << "failed to get vault info, retry after 5s, err=" << st; std::this_thread::sleep_for(5s); - } while (true); - - CHECK(!vault_infos.empty()) << "no vault infos"; + } while (vault_infos.empty()); Review Comment: while true and remember to clear vault_info each iteration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org