morrySnow commented on code in PR #33013:
URL: https://github.com/apache/doris/pull/33013#discussion_r1546026228
##########
gensrc/thrift/FrontendService.thrift:
##########
@@ -495,6 +495,11 @@ struct TFeResult {
1001: optional bool noAuth
}
+struct TTypeAndLiteral {
+ 1: required Types.TPrimitiveType type
+ 2: required string value
Review Comment:
do not use required, use optional
##########
gensrc/thrift/FrontendService.thrift:
##########
@@ -495,6 +495,11 @@ struct TFeResult {
1001: optional bool noAuth
}
+struct TTypeAndLiteral {
+ 1: required Types.TPrimitiveType type
+ 2: required string value
Review Comment:
why value is string? i think we should use TExprNode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
