HappenLee commented on code in PR #32180:
URL: https://github.com/apache/doris/pull/32180#discussion_r1546017046
##########
be/src/vec/runtime/shared_hash_table_controller.h:
##########
@@ -40,17 +40,20 @@ namespace pipeline {
class Dependency;
}
-namespace vectorized {
-
-class Arena;
-
-struct SharedRuntimeFilterContext {
+struct RuntimeFilterContext {
std::shared_ptr<MinMaxFuncBase> minmax_func;
std::shared_ptr<HybridSetBase> hybrid_set;
std::shared_ptr<BloomFilterFuncBase> bloom_filter_func;
std::shared_ptr<BitmapFilterFuncBase> bitmap_filter_func;
+ bool ignored = false;
};
+using SharedRuntimeFilterContext = std::shared_ptr<RuntimeFilterContext>;
Review Comment:
why change the struct to shared_ptr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
