zhiqiang-hhhh commented on code in PR #32010:
URL: https://github.com/apache/doris/pull/32010#discussion_r1545952868
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -3163,36 +3178,30 @@ public class PipelineExecContext {
TPipelineFragmentParams rpcParams;
PlanFragmentId fragmentId;
boolean initiated;
- volatile boolean done;
- boolean hasCanceled;
+ boolean done;
// use for pipeline
- Map<TUniqueId, RuntimeProfile> fragmentInstancesMap;
+ Map<TUniqueId, Boolean> fragmentInstancesMap;
// use for pipelineX
- List<RuntimeProfile> taskProfile;
boolean enablePipelineX;
- RuntimeProfile loadChannelProfile;
- int profileFragmentId;
TNetworkAddress brpcAddress;
TNetworkAddress address;
Backend backend;
long lastMissingHeartbeatTime = -1;
long profileReportProgress = 0;
long beProcessEpoch = 0;
private final int numInstances;
- final ExecutionProfile executionProfile;
+ private boolean hasCancelled = false;
+ private boolean cancelInProcess = false;
- public PipelineExecContext(PlanFragmentId fragmentId, int
profileFragmentId,
+ public PipelineExecContext(PlanFragmentId fragmentId,
TPipelineFragmentParams rpcParams, Long backendId,
- Map<TUniqueId, RuntimeProfile> fragmentInstancesMap,
- RuntimeProfile loadChannelProfile, boolean enablePipelineX,
final ExecutionProfile executionProfile) {
- this.profileFragmentId = profileFragmentId;
+ Map<TUniqueId, Boolean> fragmentInstancesMap,
+ boolean enablePipelineX, ExecutionProfile executionProfile) {
Review Comment:
The constructor just updates the ExecutionProfile by using fragmentId,
backendId or TPipelineFragmentParams. So the update of ExecutionProfile has
nothing to do with PipelineExecContext
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/ProfileManager.java:
##########
@@ -122,23 +127,56 @@ private ProfileManager() {
writeLock = lock.writeLock();
queryIdDeque = new LinkedList<>();
queryIdToProfileMap = new ConcurrentHashMap<>();
+ queryIdToExecutionProfiles = Maps.newHashMap();
Review Comment:
这个 map 跟 129 行的 queryIdToProfileMap 是否有重合
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
