morningman commented on code in PR #33016:
URL: https://github.com/apache/doris/pull/33016#discussion_r1545690428
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1883,6 +1903,75 @@ private void sendResult(boolean isOutfileQuery, boolean
isSendFields, Queriable
}
}
+ private void outfileWriteSuccess(OutFileClause outFileClause) throws
Exception {
+ if (!Strings.isNullOrEmpty(outFileClause.getSuccessFileName())) {
+ // 1. set TResultFileSinkOptions
+ TResultFileSinkOptions sinkOptions = new
TResultFileSinkOptions(outFileClause.getFilePath(),
Review Comment:
Why not using `outfileClause.toSinkOptions()`?
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1883,6 +1903,75 @@ private void sendResult(boolean isOutfileQuery, boolean
isSendFields, Queriable
}
}
+ private void outfileWriteSuccess(OutFileClause outFileClause) throws
Exception {
+ if (!Strings.isNullOrEmpty(outFileClause.getSuccessFileName())) {
Review Comment:
Already check it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
