github-actions[bot] commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1544065493
##########
be/src/pipeline/pipeline_x/pipeline_x_task.cpp:
##########
@@ -327,6 +305,50 @@ Status PipelineXTask::execute(bool* eos) {
return status;
}
+bool PipelineXTask::should_revoke_memory(RuntimeState* state, int64_t
revocable_mem_bytes) {
+ auto* query_ctx = state->get_query_ctx();
+ auto wg = query_ctx->workload_group();
+ if (!wg) {
+ LOG_ONCE(INFO) << "no workload group for query " <<
print_id(state->query_id());
+ return false;
+ }
+ bool is_wg_mem_low_water_mark = false;
+ bool is_wg_mem_high_water_mark = false;
+ wg->check_mem_used(&is_wg_mem_low_water_mark, &is_wg_mem_high_water_mark);
+ if (is_wg_mem_high_water_mark) {
+ if (revocable_mem_bytes > 0) {
+ LOG_EVERY_N(INFO, 5) << "revoke memory, hight water mark";
+ return true;
Review Comment:
warning: redundant boolean literal in conditional return statement
[readability-simplify-boolean-expr]
be/src/pipeline/pipeline_x/pipeline_x_task.cpp:318:
```diff
- if (revocable_mem_bytes > 0) {
- LOG_EVERY_N(INFO, 5) << "revoke memory, hight water mark";
- return true;
- }
- return false;
+ return revocable_mem_bytes > 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
