cambyzju commented on code in PR #33006:
URL: https://github.com/apache/doris/pull/33006#discussion_r1544045396


##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -852,6 +852,10 @@ void VNodeChannel::cancel(const std::string& cancel_msg) {
     // But do we need brpc::StartCancel(call_id)?
     _cancel_with_msg(cancel_msg);
 
+    if (_stub == nullptr) {

Review Comment:
   _stub is created in VNodeChannel::init, if _stub is null, it will set 
_is_closed to true.
   We should not reach here normally.
   
   If we do not find the root case, please add some comments and logs here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to