zhannngchen commented on code in PR #32991:
URL: https://github.com/apache/doris/pull/32991#discussion_r1544001549
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -930,7 +931,14 @@ bool operator!=(const TabletMeta& a, const TabletMeta& b) {
}
DeleteBitmap::DeleteBitmap(int64_t tablet_id) : _tablet_id(tablet_id) {
- _agg_cache.reset(new AggCache(config::delete_bitmap_agg_cache_capacity));
+ // The default delete bitmap cache is set to 100MB,
+ // which can be insufficient and cause performance issues when the amount
of user data is large.
+ // To mitigate the problem of an inadequate cache,
+ // we will take the larger of 5% of the total memory and 100MB as the
delete bitmap cache size.
+ int64_t mem = 0.05 * MemInfo::physical_mem();
Review Comment:
5% is too big, should be 0.5%
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
