github-actions[bot] commented on code in PR #32945:
URL: https://github.com/apache/doris/pull/32945#discussion_r1542274305
##########
be/src/vec/exec/join/vjoin_node_base.h:
##########
@@ -57,22 +56,20 @@ class VJoinNodeBase : public ExecNode {
public:
VJoinNodeBase(ObjectPool* pool, const TPlanNode& tnode, const
DescriptorTbl& descs);
- virtual Status prepare(RuntimeState* state) override;
+ Status prepare(RuntimeState* state) override;
- virtual Status close(RuntimeState* state) override;
+ Status close(RuntimeState* state) override;
- virtual Status open(RuntimeState* state) override;
+ Status open(RuntimeState* state) override;
- virtual const RowDescriptor& row_desc() const override { return
*_output_row_desc; }
+ const RowDescriptor& row_desc() const override { return *_output_row_desc;
}
Review Comment:
warning: function 'row_desc' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] const RowDescriptor& row_desc() const override { return
*_output_row_desc; }
```
##########
be/src/exec/exec_node.h:
##########
@@ -21,10 +21,10 @@
#pragma once
#include <gen_cpp/PlanNodes_types.h>
Review Comment:
warning: 'gen_cpp/PlanNodes_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/PlanNodes_types.h>
^
```
##########
be/src/vec/exprs/vexpr_context.h:
##########
@@ -20,6 +20,7 @@
#include <glog/logging.h>
Review Comment:
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
```cpp
#include <glog/logging.h>
^
```
##########
be/src/vec/runtime/vdata_stream_recvr.h:
##########
@@ -20,11 +20,11 @@
#include <gen_cpp/Types_types.h>
Review Comment:
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Types_types.h>
^
```
##########
be/src/vec/exprs/vslot_ref.h:
##########
@@ -38,15 +38,14 @@
public:
VSlotRef(const doris::TExprNode& node);
VSlotRef(const SlotDescriptor* desc);
- virtual doris::Status execute(VExprContext* context,
doris::vectorized::Block* block,
- int* result_column_id) override;
- virtual doris::Status prepare(doris::RuntimeState* state, const
doris::RowDescriptor& desc,
- VExprContext* context) override;
- VExprSPtr clone() const override { return VSlotRef::create_shared(*this); }
-
- virtual const std::string& expr_name() const override;
- virtual std::string debug_string() const override;
- virtual bool is_constant() const override { return false; }
+ Status prepare(RuntimeState* state, const RowDescriptor& desc,
VExprContext* context) override;
+ Status open(RuntimeState* state, VExprContext* context,
+ FunctionContext::FunctionStateScope scope) override;
+ Status execute(VExprContext* context, Block* block, int* result_column_id)
override;
+
+ const std::string& expr_name() const override;
+ std::string debug_string() const override;
Review Comment:
warning: function 'debug_string' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] std::string debug_string() const override;
```
##########
be/src/vec/exec/join/vjoin_node_base.h:
##########
@@ -57,22 +56,20 @@
public:
VJoinNodeBase(ObjectPool* pool, const TPlanNode& tnode, const
DescriptorTbl& descs);
- virtual Status prepare(RuntimeState* state) override;
+ Status prepare(RuntimeState* state) override;
- virtual Status close(RuntimeState* state) override;
+ Status close(RuntimeState* state) override;
- virtual Status open(RuntimeState* state) override;
+ Status open(RuntimeState* state) override;
- virtual const RowDescriptor& row_desc() const override { return
*_output_row_desc; }
+ const RowDescriptor& row_desc() const override { return *_output_row_desc;
}
- virtual const RowDescriptor& intermediate_row_desc() const override {
- return *_intermediate_row_desc;
- }
+ const RowDescriptor& intermediate_row_desc() const override { return
*_intermediate_row_desc; }
Review Comment:
warning: function 'intermediate_row_desc' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] const RowDescriptor& intermediate_row_desc() const
override { return *_intermediate_row_desc; }
```
##########
be/src/vec/exprs/vslot_ref.h:
##########
@@ -38,15 +38,14 @@
public:
VSlotRef(const doris::TExprNode& node);
VSlotRef(const SlotDescriptor* desc);
- virtual doris::Status execute(VExprContext* context,
doris::vectorized::Block* block,
- int* result_column_id) override;
- virtual doris::Status prepare(doris::RuntimeState* state, const
doris::RowDescriptor& desc,
- VExprContext* context) override;
- VExprSPtr clone() const override { return VSlotRef::create_shared(*this); }
-
- virtual const std::string& expr_name() const override;
- virtual std::string debug_string() const override;
- virtual bool is_constant() const override { return false; }
+ Status prepare(RuntimeState* state, const RowDescriptor& desc,
VExprContext* context) override;
+ Status open(RuntimeState* state, VExprContext* context,
+ FunctionContext::FunctionStateScope scope) override;
+ Status execute(VExprContext* context, Block* block, int* result_column_id)
override;
+
+ const std::string& expr_name() const override;
+ std::string debug_string() const override;
+ bool is_constant() const override { return false; }
Review Comment:
warning: function 'is_constant' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_constant() const override { return false; }
```
##########
be/src/vec/exprs/vslot_ref.h:
##########
@@ -38,15 +38,14 @@ class VSlotRef final : public VExpr {
public:
VSlotRef(const doris::TExprNode& node);
VSlotRef(const SlotDescriptor* desc);
- virtual doris::Status execute(VExprContext* context,
doris::vectorized::Block* block,
- int* result_column_id) override;
- virtual doris::Status prepare(doris::RuntimeState* state, const
doris::RowDescriptor& desc,
- VExprContext* context) override;
- VExprSPtr clone() const override { return VSlotRef::create_shared(*this); }
-
- virtual const std::string& expr_name() const override;
- virtual std::string debug_string() const override;
- virtual bool is_constant() const override { return false; }
+ Status prepare(RuntimeState* state, const RowDescriptor& desc,
VExprContext* context) override;
+ Status open(RuntimeState* state, VExprContext* context,
+ FunctionContext::FunctionStateScope scope) override;
+ Status execute(VExprContext* context, Block* block, int* result_column_id)
override;
+
+ const std::string& expr_name() const override;
Review Comment:
warning: function 'expr_name' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] const std::string& expr_name() const override;
```
##########
be/src/vec/exprs/vexpr.h:
##########
@@ -119,8 +117,15 @@ class VExpr {
virtual Status open(RuntimeState* state, VExprContext* context,
FunctionContext::FunctionStateScope scope);
- virtual Status execute(VExprContext* context, vectorized::Block* block,
- int* result_column_id) = 0;
+ // before execute, check if expr has been parepared+opened.
+ [[maybe_unused]] Status ready_status() const {
Review Comment:
warning: function 'ready_status' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[maybe_unused]] [[nodiscard]] Status ready_status() const {
```
##########
be/src/pipeline/exec/operator.h:
##########
@@ -19,13 +19,11 @@
#include <fmt/format.h>
Review Comment:
warning: 'fmt/format.h' file not found [clang-diagnostic-error]
```cpp
#include <fmt/format.h>
^
```
##########
be/src/vec/exprs/vlambda_function_call_expr.h:
##########
@@ -36,6 +36,8 @@ class VLambdaFunctionCallExpr : public VExpr {
VExprSPtr clone() const override { return
VLambdaFunctionCallExpr::create_shared(*this); }
+ const std::string& expr_name() const override { return _expr_name; }
Review Comment:
warning: function 'expr_name' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] const std::string& expr_name() const override { return
_expr_name; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
