github-actions[bot] commented on code in PR #32785:
URL: https://github.com/apache/doris/pull/32785#discussion_r1540654888
##########
be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:
##########
@@ -119,6 +126,12 @@ void ColumnChunkReader::_get_uncompressed_levels(const
tparquet::DataPageHeaderV
}
Status ColumnChunkReader::load_page_data() {
Review Comment:
warning: function 'load_page_data' has cognitive complexity of 80 (threshold
50) [readability-function-cognitive-complexity]
```cpp
Status ColumnChunkReader::load_page_data() {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:128:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_offset_index) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:130:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_page_reader->parse_page_header());
^
```
**be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:130:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_page_reader->parse_page_header());
^
```
**be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:134:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (UNLIKELY(_state != HEADER_PARSED)) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:140:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_block_compress_codec != nullptr) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:142:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_page_reader->get_page_data(compressed_data));
^
```
**be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:142:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_page_reader->get_page_data(compressed_data));
^
```
**be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:143:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (header.__isset.data_page_header_v2) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:152:** +1
```cpp
header.__isset.data_page_header_v2 &&
header.data_page_header_v2.is_compressed;
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:153:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (header.__isset.data_page_header || is_v2_compressed) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:153:** +1
```cpp
if (header.__isset.data_page_header || is_v2_compressed) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:159:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_block_compress_codec->decompress(compressed_data,
&_page_data));
^
```
**be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:159:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_block_compress_codec->decompress(compressed_data,
&_page_data));
^
```
**be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:160:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:164:** +1,
nesting level increased to 1
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:165:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_page_reader->get_page_data(_page_data));
^
```
**be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:165:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_page_reader->get_page_data(_page_data));
^
```
**be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:166:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (header.__isset.data_page_header_v2) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:172:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_max_rep_level > 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:174:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (header.__isset.data_page_header_v2) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:175:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_rep_level_decoder.init_v2(_v2_rep_levels,
_max_rep_level,
^
```
**be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:175:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_rep_level_decoder.init_v2(_v2_rep_levels,
_max_rep_level,
^
```
**be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:177:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:178:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_rep_level_decoder.init(
^
```
**be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:178:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_rep_level_decoder.init(
^
```
**be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:183:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_max_def_level > 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:185:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (header.__isset.data_page_header_v2) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:186:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_def_level_decoder.init_v2(_v2_def_levels,
_max_def_level,
^
```
**be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:186:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_def_level_decoder.init_v2(_v2_def_levels,
_max_def_level,
^
```
**be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:188:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:189:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_def_level_decoder.init(
^
```
**be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:189:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_def_level_decoder.init(
^
```
**be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:194:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
auto encoding = header.__isset.data_page_header_v2 ?
header.data_page_header_v2.encoding
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:197:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (encoding == tparquet::Encoding::PLAIN_DICTIONARY) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:202:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_decoders.find(static_cast<int>(encoding)) != _decoders.end()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:204:** +1,
nesting level increased to 1
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:206:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(Decoder::get_decoder(_metadata.type, encoding,
page_decoder));
^
```
**be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp:206:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(Decoder::get_decoder(_metadata.type, encoding,
page_decoder));
^
```
**be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
