yiguolei commented on code in PR #32783:
URL: https://github.com/apache/doris/pull/32783#discussion_r1540356855
##########
be/src/pipeline/exec/partitioned_hash_join_probe_operator.cpp:
##########
@@ -174,29 +174,36 @@ Status
PartitionedHashJoinProbeLocalState::spill_build_block(RuntimeState* state
auto* spill_io_pool =
ExecEnv::GetInstance()->spill_stream_mgr()->get_spill_io_thread_pool(
build_spilling_stream->get_spill_root_dir());
- return spill_io_pool->submit_func([state, &build_spilling_stream,
&mutable_block, this] {
- (void)state; // avoid ut compile error
- SCOPED_ATTACH_TASK(state);
- if (_spill_status_ok) {
- auto build_block = mutable_block->to_block();
- DCHECK_EQ(mutable_block->rows(), 0);
- auto st = build_spilling_stream->spill_block(build_block, false);
- if (!st.ok()) {
- std::unique_lock<std::mutex> lock(_spill_lock);
- _spill_status_ok = false;
- _spill_status = std::move(st);
- } else {
- COUNTER_UPDATE(_spill_build_rows, build_block.rows());
- COUNTER_UPDATE(_spill_build_blocks, 1);
- }
- }
- --_spilling_task_count;
+ auto execution_context_ = state->get_task_execution_context();
+ _shared_state_holder = _shared_state->shared_from_this();
+ return spill_io_pool->submit_func(
+ [execution_context_, state, &build_spilling_stream,
&mutable_block, this] {
Review Comment:
And also here, please use copy-value not use reference in lambda object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
