github-actions[bot] commented on code in PR #32695: URL: https://github.com/apache/doris/pull/32695#discussion_r1538670258
########## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ########## @@ -1777,13 +1777,13 @@ Status SegmentIterator::_read_columns(const std::vector<ColumnId>& column_ids, return Status::OK(); } -void SegmentIterator::_init_current_block( +Status SegmentIterator::_init_current_block( Review Comment: warning: method '_init_current_block' can be made static [readability-convert-member-functions-to-static] ```suggestion static ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org