eldenmoon commented on code in PR #32780:
URL: https://github.com/apache/doris/pull/32780#discussion_r1538527107
##########
be/src/vec/data_types/serde/data_type_object_serde.h:
##########
@@ -73,10 +73,7 @@ class DataTypeObjectSerDe : public DataTypeSerDe {
void write_column_to_arrow(const IColumn& column, const NullMap* null_map,
arrow::ArrayBuilder* array_builder, int start,
int end,
- const cctz::time_zone& ctz) const override {
- throw doris::Exception(ErrorCode::NOT_IMPLEMENTED_ERROR,
- "write_column_to_arrow with type " +
column.get_name());
- }
+ const cctz::time_zone& ctz) const override;
void read_column_from_arrow(IColumn& column, const arrow::Array*
arrow_array, int start,
Review Comment:
currently this pr is to solve the connector problem for variant, for read
from arrow we could use cast expr like cast(xxx as variant)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
