github-actions[bot] commented on code in PR #32783:
URL: https://github.com/apache/doris/pull/32783#discussion_r1537839362


##########
be/src/pipeline/exec/partitioned_hash_join_probe_operator.cpp:
##########
@@ -152,12 +156,21 @@ Status 
PartitionedHashJoinProbeLocalState::close(RuntimeState* state) {
     return Status::OK();
 }
 
+void PartitionedHashJoinProbeLocalState::_decrease_spilling_tasks_count() {

Review Comment:
   warning: method '_decrease_spilling_tasks_count' can be made static 
[readability-convert-member-functions-to-static]
   
   be/src/pipeline/exec/partitioned_hash_join_probe_operator.h:72:
   ```diff
   -     void _decrease_spilling_tasks_count();
   +     static void _decrease_spilling_tasks_count();
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to