AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2017528076
> @AcKing-Sam btw, maybe we should modify logical in `convert_to_decimals`
instead of using a temporary array which costs more memory and does not have
performance benefits. For example, add check and do cast to int64 if from type
is Date/Datetime.
>
> Do you think which one is better?
Yes, I think the second way is better and I will try to change the committed
code.
The code should be like:
```cpp
else if (type is date or datetime) {
// instead of using array: typename FromDataType::FieldType tmp[size];
// directly check here, may reuse some code in convert_to_decimals function
// if okay, directly change to int64
// else take an error
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
