gavinchou commented on code in PR #32738:
URL: https://github.com/apache/doris/pull/32738#discussion_r1537104327
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -2666,11 +2671,45 @@ public void updateVisibleVersionAndTime(long
visibleVersion, long visibleVersion
// During `getNextVersion` and `updateVisibleVersionAndTime` period,
// the write lock on the table should be held continuously
public long getNextVersion() {
- return tableAttributes.getNextVersion();
+ if (!Config.isCloudMode()) {
+ return tableAttributes.getNextVersion();
+ } else {
+ return getVisibleVersion() + 1;
+ }
}
public long getVisibleVersion() {
- return tableAttributes.getVisibleVersion();
+ if (Config.isCloudMode()) {
+ return tableAttributes.getVisibleVersion();
+ } else {
+ // get version rpc
+ Cloud.GetVersionRequest request =
Cloud.GetVersionRequest.newBuilder()
Review Comment:
```suggestion
if (Config.isNotCloudMode()) {
return tableAttributes.getVisibleVersion();
}
// get version rpc
Cloud.GetVersionRequest request =
Cloud.GetVersionRequest.newBuilder()
```
It should be `if (Config.isNotCloudMode())`. and,
the `else` block is redundant, because `isNotCloudMode` has already returned.
remove `else` to reduce indention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
