yiguolei commented on code in PR #32717: URL: https://github.com/apache/doris/pull/32717#discussion_r1536649552
########## be/src/pipeline/exec/data_queue.cpp: ########## @@ -146,6 +151,10 @@ void DataQueue::push_block(std::unique_ptr<vectorized::Block> block, int child_i if (_source_dependency) { set_source_ready(); } + + if (_spill_dependencies[child_idx]) { Review Comment: 我们不应当修改data queue的结构,dataqueue 是一个核心的数据结构,他只应该负责queue的逻辑。设想一下,假如我们的data queue 是使用的第三方的实现怎么办? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org