github-actions[bot] commented on code in PR #32725:
URL: https://github.com/apache/doris/pull/32725#discussion_r1536624762
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -1061,10 +1061,10 @@ Status FileColumnIterator::seek_to_page_start() {
return seek_to_ordinal(_page.first_ordinal);
}
-void FileColumnIterator::_seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) const {
+Status FileColumnIterator::_seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) const {
Review Comment:
warning: method '_seek_to_pos_in_page' can be made static
[readability-convert-member-functions-to-static]
```suggestion
Status FileColumnIterator::_seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) {
```
be/src/olap/rowset/segment_v2/column_reader.h:369:
```diff
- Status _seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) const;
+ static Status _seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) ;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
