github-actions[bot] commented on PR #32648:
URL: https://github.com/apache/doris/pull/32648#issuecomment-2012848779
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/8378283125";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build-for-release.sh line 160:
cd `ls -F | grep "tzdb-.*/$"`
^------------------------^ SC2046 (warning): Quote this to prevent word
splitting.
^------------------------^ SC2006 (style): Use $(...) notation instead of
legacy backticks `...`.
^-- SC2010 (warning): Don't use ls | grep. Use a glob or a for loop with
a condition to allow non-alphanumeric filenames.
Did you mean:
cd $(ls -F | grep "tzdb-.*/$")
In build-for-release.sh line 166:
rm -r `ls | grep -v "zoneinfo.tar.gz"`
^-- SC2046 (warning): Quote this to prevent word splitting.
^-- SC2006 (style): Use $(...) notation instead of legacy backticks
`...`.
^-- SC2010 (warning): Don't use ls | grep. Use a glob or a for loop
with a condition to allow non-alphanumeric filenames.
Did you mean:
rm -r $(ls | grep -v "zoneinfo.tar.gz")
For more information:
https://www.shellcheck.net/wiki/SC2010 -- Don't use ls | grep. Use a glob
o...
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word
splitt...
https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of
le...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build-for-release.sh.orig
+++ build-for-release.sh
@@ -146,7 +146,7 @@
echo "JAR: ${OUTPUT_EXT}"
# Sync the latest timezone date files
-if ! command -v lzip > /dev/null 2>&1; then
+if ! command -v lzip >/dev/null 2>&1; then
echo "need lzip to undecompresse the tzdb file but does not exist."
exit 1
fi
@@ -157,13 +157,13 @@
wget https://www.iana.org/time-zones/repository/tzdb-latest.tar.lz
lzip -d tzdb-latest.tar.lz
tar -xf tzdb-latest.tar
-cd `ls -F | grep "tzdb-.*/$"`
+cd $(ls -F | grep "tzdb-.*/$")
make TOPDIR="../zone_output" install
cd ../zone_output/usr/share
tar -czf zoneinfo.tar.gz zoneinfo
mv zoneinfo.tar.gz ../../..
cd ../../..
-rm -r `ls | grep -v "zoneinfo.tar.gz"`
+rm -r $(ls | grep -v "zoneinfo.tar.gz")
popd
echo "Succeed to get newest time zone database file"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
