wangshuo128 edited a comment on pull request #7076: URL: https://github.com/apache/incubator-doris/pull/7076#issuecomment-964871525
Nit: should we unify the prefix of configs that means "enable something", "close something", "disable something", etc. IIUC, the unified naming strategy would help end-users to use our system more easily. Considering that we have already lots of configs starting with "enable_", I'd suggest renaming `close_join_reorder` to `enable_join_reorder`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
