morningman commented on code in PR #32458:
URL: https://github.com/apache/doris/pull/32458#discussion_r1530140051
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetadataOps.java:
##########
@@ -124,15 +126,32 @@ public void createTable(CreateTableStmt stmt) throws
UserException {
throw new UserException("Failed to get database: '" + dbName + "'
in catalog: " + catalog.getName());
}
try {
- Map<String, String> props = stmt.getExtProperties();
+ Map<String, String> props = stmt.getProperties();
String fileFormat = props.getOrDefault("file_format",
Config.hive_default_file_format);
- HiveTableMetadata catalogTable = HiveTableMetadata.of(dbName,
- tblName,
- stmt.getColumns(),
- parsePartitionKeys(props),
- props,
- fileFormat);
-
+ List<String> partitionColNames =
stmt.getPartitionDesc().getPartitionColNames();
+ HiveTableMetadata catalogTable;
+ DistributionDesc bucketInfo = stmt.getDistributionDesc();
+ if (bucketInfo == null) {
+ catalogTable = HiveTableMetadata.of(dbName,
+ tblName,
+ stmt.getColumns(),
+ partitionColNames,
+ props,
+ fileFormat);
+ } else {
+ if (bucketInfo instanceof HashDistributionDesc) {
Review Comment:
Better disable the bucket for now? Because we are now support it yet
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetadataOps.java:
##########
@@ -124,15 +126,32 @@ public void createTable(CreateTableStmt stmt) throws
UserException {
throw new UserException("Failed to get database: '" + dbName + "'
in catalog: " + catalog.getName());
}
try {
- Map<String, String> props = stmt.getExtProperties();
+ Map<String, String> props = stmt.getProperties();
String fileFormat = props.getOrDefault("file_format",
Config.hive_default_file_format);
- HiveTableMetadata catalogTable = HiveTableMetadata.of(dbName,
- tblName,
- stmt.getColumns(),
- parsePartitionKeys(props),
- props,
- fileFormat);
-
+ List<String> partitionColNames =
stmt.getPartitionDesc().getPartitionColNames();
+ HiveTableMetadata catalogTable;
Review Comment:
```suggestion
HiveTableMetadata hiveTableMeta;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
