yiguolei commented on code in PR #32426:
URL: https://github.com/apache/doris/pull/32426#discussion_r1529569038
##########
be/src/pipeline/exec/streaming_aggregation_operator.cpp:
##########
@@ -1155,13 +1159,11 @@ Status StreamingAggOperatorX::init(const TPlanNode&
tnode, RuntimeState* state)
}
const auto& agg_functions = tnode.agg_node.aggregate_functions;
- _external_agg_bytes_threshold = state->external_agg_bytes_threshold();
-
- if (_external_agg_bytes_threshold > 0) {
- _spill_partition_count_bits = 4;
- if (state->query_options().__isset.external_agg_partition_bits) {
- _spill_partition_count_bits =
state->query_options().external_agg_partition_bits;
- }
+ if (state->enable_agg_spill()) {
+ // If spill enabled, the streaming agg should not take too much memory.
+ _external_agg_bytes_threshold = 268435456; // 256MB
Review Comment:
change to session variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
