morningman commented on code in PR #32137:
URL: https://github.com/apache/doris/pull/32137#discussion_r1525095008


##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/InternalAccessController.java:
##########
@@ -68,7 +78,27 @@ public boolean checkWorkloadGroupPriv(UserIdentity 
currentUser, String workloadG
 
     @Override
     public boolean checkCloudPriv(UserIdentity currentUser, String 
resourceName,
-                                  PrivPredicate wanted, ResourceTypeEnum type) 
{
+            PrivPredicate wanted, ResourceTypeEnum type) {
         return auth.checkResourcePriv(currentUser, resourceName, wanted);
     }
+
+    @Override
+    public Optional<DataMaskPolicy> evalDataMaskPolicy(UserIdentity 
currentUser, String ctl, String db, String tbl,
+            String col) {
+        return Optional.empty();
+    }
+
+    @Override
+    public List<? extends RowFilterPolicy> evalRowFilterPolicies(UserIdentity 
currentUser, String ctl, String db,
+            String tbl)
+            throws AnalysisException {
+        // current not support external catalog
+        if (!InternalCatalog.INTERNAL_CATALOG_NAME.equals(ctl)) {

Review Comment:
   Why not support external catalog?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to