github-actions[bot] commented on code in PR #32219:
URL: https://github.com/apache/doris/pull/32219#discussion_r1527704532
##########
be/src/vec/functions/function_string.h:
##########
@@ -1484,10 +1496,10 @@ class FunctionStringRepeat : public IFunction {
argument_ptr[0]->get_name(),
argument_ptr[1]->get_name());
}
- void vector_vector(const ColumnString::Chars& data, const
ColumnString::Offsets& offsets,
- const ColumnInt32::Container& repeats,
ColumnString::Chars& res_data,
- ColumnString::Offsets& res_offsets,
ColumnUInt8::Container& null_map,
- const int repeat_max_num) const {
+ Status vector_vector(const ColumnString::Chars& data, const
ColumnString::Offsets& offsets,
Review Comment:
warning: method 'vector_vector' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status vector_vector(const ColumnString::Chars& data, const
ColumnString::Offsets& offsets,
```
be/src/vec/functions/function_string.h:1501:
```diff
- const int repeat_max_num) const {
+ const int repeat_max_num) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
