yiguolei commented on code in PR #32346:
URL: https://github.com/apache/doris/pull/32346#discussion_r1527664509


##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -839,11 +833,8 @@ Status FragmentMgr::exec_plan_fragment(const 
TPipelineFragmentParams& params,
                 _pipeline_map.insert({ins_id, context});
             }
 
-            _cv.notify_all();
-        }
-        {
-            std::lock_guard<std::mutex> lock(query_ctx->pipeline_lock);
             query_ctx->fragment_id_to_pipeline_ctx.insert({params.fragment_id, 
context});
+            _cv.notify_all();

Review Comment:
   I do not find any call to _cv.wait, why do we need notify?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to