gavinchou commented on code in PR #32267:
URL: https://github.com/apache/doris/pull/32267#discussion_r1527565098


##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -497,12 +497,21 @@ public void commitMaterializedIndex(Long tableId, 
List<Long> indexIds) throws Dd
         if (LOG.isDebugEnabled()) {
             LOG.debug("send create tablets rpc, createTabletsReq: {}", 
createTabletsReq);
         }
-        Cloud.CreateTabletsResponse response;
-        try {
-            response = 
MetaServiceProxy.getInstance().createTablets(createTabletsReq);
-        } catch (RpcException e) {
-            LOG.warn("failed to send create tablets rpc {}", e.getMessage());
-            throw new RuntimeException(e);
+        Cloud.CreateTabletsResponse response = null;
+        int tryTimes = 0;
+        while (tryTimes++ < Config.meta_service_rpc_retry_times) {
+            try {
+                response = 
MetaServiceProxy.getInstance().createTablets(createTabletsReq);

Review Comment:
   The check of line 509 may not work because the response may remain null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to