xinyiZzz commented on code in PR #32340:
URL: https://github.com/apache/doris/pull/32340#discussion_r1527555277
##########
be/src/runtime/memory/lru_cache_policy.h:
##########
@@ -120,14 +120,17 @@ class LRUCachePolicy : public CachePolicy {
uint64_t new_id() { return _cache->new_id(); };
+ // Subclass can override this method to determine whether to do the minor
or full gc
Review Comment:
inaccurate comment. gc type only related to memory status, minor gc exectue
`prune_stale` and full gc exectue`prune_all`.
`exceed_prune_limit` only used for whether to exectue this cache prune.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
