github-actions[bot] commented on code in PR #32301: URL: https://github.com/apache/doris/pull/32301#discussion_r1527023109
########## be/src/runtime/runtime_state.h: ########## @@ -165,13 +165,22 @@ class RuntimeState { void get_unreported_errors(std::vector<std::string>* new_errors); bool is_cancelled() const { return _is_cancelled.load(); } + std::string cancel_reason() const; Review Comment: warning: function 'cancel_reason' should be marked [[nodiscard]] [modernize-use-nodiscard] ```suggestion [[nodiscard]] std::string cancel_reason() const; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org