wsjz commented on code in PR #31765:
URL: https://github.com/apache/doris/pull/31765#discussion_r1526425439
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/PostgreSQLJdbcHMSCachedClient.java:
##########
@@ -172,15 +176,27 @@ public List<Partition> getPartitions(String dbName,
String tblName, List<String>
private List<Partition> getPartitionsByNames(String dbName, String
tblName, List<String> partitionNames) {
List<String> partitionNamesWithQuote =
partitionNames.stream().map(partitionName -> "'" + partitionName + "'")
.collect(Collectors.toList());
- String partitionNamesString = Joiner.on(",
").join(partitionNamesWithQuote);
- String sql = String.format("SELECT \"PART_ID\",
\"PARTITIONS\".\"CREATE_TIME\","
- + " \"PARTITIONS\".\"LAST_ACCESS_TIME\","
- + " \"PART_NAME\", \"PARTITIONS\".\"SD_ID\" FROM
\"PARTITIONS\""
- + " join \"TBLS\" on \"TBLS\".\"TBL_ID\" =
\"PARTITIONS\".\"TBL_ID\""
- + " join \"DBS\" on \"TBLS\".\"DB_ID\" =
\"DBS\".\"DB_ID\""
- + " WHERE \"DBS\".\"NAME\" = '%s' AND
\"TBLS\".\"TBL_NAME\"='%s'"
- + " AND \"PART_NAME\" in (%s);",
- dbName, tblName, partitionNamesString);
+ String sql;
+ if (partitionNamesWithQuote.isEmpty()) {
+ sql = String.format("SELECT \"PART_ID\",
\"PARTITIONS\".\"CREATE_TIME\","
+ + " \"PARTITIONS\".\"LAST_ACCESS_TIME\","
+ + " \"PART_NAME\", \"PARTITIONS\".\"SD_ID\" FROM
\"PARTITIONS\""
+ + " join \"TBLS\" on \"TBLS\".\"TBL_ID\" =
\"PARTITIONS\".\"TBL_ID\""
+ + " join \"DBS\" on \"TBLS\".\"DB_ID\" =
\"DBS\".\"DB_ID\""
+ + " WHERE \"DBS\".\"NAME\" = '%s' AND
\"TBLS\".\"TBL_NAME\"='%s'"
+ + " AND \"PART_NAME\";",
Review Comment:
we need listPartitions when use postgresql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
