github-actions[bot] commented on code in PR #32317:
URL: https://github.com/apache/doris/pull/32317#discussion_r1526277629
##########
be/src/pipeline/exec/repeat_operator.cpp:
##########
@@ -158,6 +158,17 @@ Status
RepeatLocalState::get_repeated_block(vectorized::Block* child_block, int
const auto rows = child_block->rows();
// Fill grouping ID to block
+ RETURN_IF_ERROR(add_grouping_id_column(rows, cur_col, columns,
repeat_id_idx));
+
+ DCHECK_EQ(cur_col, column_size);
+
+ return Status::OK();
+}
+
+Status RepeatLocalState::add_grouping_id_column(std::size_t rows, std::size_t&
cur_col,
Review Comment:
warning: method 'add_grouping_id_column' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status RepeatLocalState::add_grouping_id_column(std::size_t rows,
std::size_t& cur_col,
```
##########
be/src/vec/exec/vrepeat_node.cpp:
##########
@@ -153,6 +153,15 @@ Status VRepeatNode::get_repeated_block(Block* child_block,
int repeat_id_idx, Bl
const auto rows = child_block->rows();
// Fill grouping ID to block
+ RETURN_IF_ERROR(add_grouping_id_column(rows, cur_col, columns,
repeat_id_idx));
+ output_block->set_columns(std::move(columns));
+ DCHECK_EQ(cur_col, column_size);
+
+ return Status::OK();
+}
+
+Status VRepeatNode::add_grouping_id_column(std::size_t rows, std::size_t&
cur_col,
Review Comment:
warning: method 'add_grouping_id_column' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status VRepeatNode::add_grouping_id_column(std::size_t rows,
std::size_t& cur_col,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
