xiaokang commented on code in PR #32279:
URL: https://github.com/apache/doris/pull/32279#discussion_r1525973520
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -249,15 +253,16 @@ class BkdIndexReader : public InvertedIndexReader {
Status query(OlapReaderStatistics* stats, RuntimeState* runtime_state,
const std::string& column_name, const void* query_value,
- InvertedIndexQueryType query_type, roaring::Roaring* bit_map)
override;
+ InvertedIndexQueryType query_type,
+ std::shared_ptr<roaring::Roaring>& bit_map) override;
Status try_query(OlapReaderStatistics* stats, const std::string&
column_name,
const void* query_value, InvertedIndexQueryType
query_type,
uint32_t* count) override;
Status invoke_bkd_try_query(const void* query_value,
InvertedIndexQueryType query_type,
std::shared_ptr<lucene::util::bkd::bkd_reader>
r, uint32_t* count);
Status invoke_bkd_query(const void* query_value, InvertedIndexQueryType
query_type,
std::shared_ptr<lucene::util::bkd::bkd_reader> r,
- roaring::Roaring* bit_map);
+ std::shared_ptr<roaring::Roaring> bit_map);
Review Comment:
Why not & as other functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
