github-actions[bot] commented on code in PR #32039: URL: https://github.com/apache/doris/pull/32039#discussion_r1525667098
########## be/src/runtime/thread_context.cpp: ########## @@ -23,11 +23,17 @@ namespace doris { class MemTracker; -AttachTask::AttachTask(const std::shared_ptr<MemTrackerLimiter>& mem_tracker, - const TUniqueId& task_id) { +QueryThreadContext ThreadContext::query_thread_context() { Review Comment: warning: method 'query_thread_context' can be made const [readability-make-member-function-const] be/src/runtime/thread_context.h:183: ```diff - QueryThreadContext query_thread_context(); + QueryThreadContext query_thread_context() const; ``` ```suggestion QueryThreadContext ThreadContext::query_thread_context() const { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org