yiguolei commented on code in PR #32259:
URL: https://github.com/apache/doris/pull/32259#discussion_r1524928249


##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -618,10 +619,29 @@ public void exec() throws Exception {
                         throw new UserException("could not find query queue");
                     }
                     queueToken = queryQueue.getToken();
-                    if 
(!queueToken.waitSignal(this.queryOptions.getExecutionTimeout() * 1000)) {
-                        LOG.error("query (id=" + DebugUtil.printId(queryId) + 
") " + queueToken.getOfferResultDetail());
-                        queryQueue.returnToken(queueToken);
-                        throw new 
UserException(queueToken.getOfferResultDetail());
+                    long queueStartTime = System.currentTimeMillis();

Review Comment:
   这么改不好,容易锁死。
   直接把queue start time和queue end time 放到queue token 里,然后token 
本身是coordinator的一个属性就ok了。
   当我们显示的时候,直接从token 里拿start time和end time 就可以了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to