github-actions[bot] commented on code in PR #32208:
URL: https://github.com/apache/doris/pull/32208#discussion_r1524916013
##########
be/src/olap/tablet_reader.cpp:
##########
@@ -558,7 +558,7 @@ Status TabletReader::_init_conditions_param(const
ReaderParams& read_params) {
return Status::OK();
}
-void TabletReader::_init_conditions_param_except_leafnode_of_andnode(
+Status TabletReader::_init_conditions_param_except_leafnode_of_andnode(
Review Comment:
warning: method '_init_conditions_param_except_leafnode_of_andnode' can be
made static [readability-convert-member-functions-to-static]
be/src/olap/tablet_reader.h:244:
```diff
- Status _init_conditions_param_except_leafnode_of_andnode(const
ReaderParams& read_params);
+ static Status _init_conditions_param_except_leafnode_of_andnode(const
ReaderParams& read_params);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
