github-actions[bot] commented on code in PR #32204:
URL: https://github.com/apache/doris/pull/32204#discussion_r1523514613
##########
be/src/runtime/query_context.cpp:
##########
@@ -214,21 +214,21 @@ doris::pipeline::TaskScheduler*
QueryContext::get_pipe_exec_scheduler() {
}
ThreadPool* QueryContext::get_non_pipe_exec_thread_pool() {
- if (_task_group) {
+ if (_workload_group) {
return _non_pipe_thread_pool;
} else {
return nullptr;
}
}
-Status QueryContext::set_task_group(taskgroup::TaskGroupPtr& tg) {
- _task_group = tg;
- // Should add query first, then the task group will not be deleted.
- // see task_group_manager::delete_task_group_by_ids
- RETURN_IF_ERROR(_task_group->add_query(_query_id));
- _task_group->add_mem_tracker_limiter(query_mem_tracker);
- _task_group->get_query_scheduler(&_task_scheduler, &_scan_task_scheduler,
- &_non_pipe_thread_pool,
&_remote_scan_task_scheduler);
+Status QueryContext::set_workload_group(WorkloadGroupPtr& tg) {
Review Comment:
warning: method 'set_workload_group' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/query_context.h:165:
```diff
- Status set_workload_group(WorkloadGroupPtr& tg);
+ static Status set_workload_group(WorkloadGroupPtr& tg);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
