BiteTheDDDDt commented on code in PR #31913:
URL: https://github.com/apache/doris/pull/31913#discussion_r1522901941
##########
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##########
@@ -491,25 +574,23 @@ class AggregateFunctionCollect
void merge(AggregateDataPtr __restrict place, ConstAggregateDataPtr rhs,
Arena* arena) const override {
auto& data = this->data(place);
- auto& rhs_data = this->data(rhs);
+ const auto& rhs_data = this->data(rhs);
if constexpr (ENABLE_ARENA) {
data.merge(rhs_data, arena);
} else if constexpr (!ShowNull::value) {
data.merge(rhs_data);
Review Comment:
why two branch have same code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
