EmmyMiao87 commented on a change in pull request #6958:
URL: https://github.com/apache/incubator-doris/pull/6958#discussion_r738918734
##########
File path: be/src/olap/rowset/column_reader.h
##########
@@ -184,20 +185,20 @@ class ColumnReader {
ColumnReader(uint32_t column_id, uint32_t column_unique_id);
virtual ~ColumnReader();
- // 使用streams初始化Reader
- // ColumnReader仅初始化一次，每次使用时分配新的对象。
+ // Use streams to initialize Reader
+ // ColumnReader is initialized only once, and a new object is allocated
each time it is used.
// Input:
- // streams - 输入stream
+ // streams-input stream
virtual OLAPStatus init(std::map<StreamName, ReadOnlyFileStream*>*
streams, int size,
MemPool* mem_pool, OlapReaderStatistics* stats);
- // 设置下一个返回的数据的位置
- // positions是各个列需要seek的位置, ColumnReader通过(*positions)[_column_unique_id]
- // 获得本列需要seek的位置
+ // Set the position of the next returned data
+ // positions are the positions where each column needs to seek,
ColumnReader passes (*positions)[_column_unique_id]
+ // Get the seek position of this column
virtual OLAPStatus seek(PositionProvider* positions);
- // TODO. 这点不是很明白，为什么present不用skip，
- // 如果上层skip过而底层不skip，next判断空不空不是不准了吗
+ // TODO. It’s not very clear, why don’t present skip,
Review comment:
Remove it ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
