englefly commented on code in PR #31875:
URL: https://github.com/apache/doris/pull/31875#discussion_r1517300085
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java:
##########
@@ -404,4 +404,15 @@ public static boolean
checkReorderPrecondition(LogicalJoin<?, ?> top, LogicalJoi
markSlots.retainAll(bottom.getOutputSet());
return markSlots.isEmpty();
}
+
+ public static boolean isSemiOrAntiJoin(JoinType joinType) {
+ return joinType == JoinType.LEFT_SEMI_JOIN || joinType ==
JoinType.RIGHT_SEMI_JOIN
+ || joinType == JoinType.LEFT_ANTI_JOIN || joinType ==
JoinType.RIGHT_ANTI_JOIN;
+ }
+
+ public static boolean isOuterJoin(JoinType joinType) {
Review Comment:
duplicates to JoinType.isOuterJoin()
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java:
##########
@@ -404,4 +404,15 @@ public static boolean
checkReorderPrecondition(LogicalJoin<?, ?> top, LogicalJoi
markSlots.retainAll(bottom.getOutputSet());
return markSlots.isEmpty();
}
+
+ public static boolean isSemiOrAntiJoin(JoinType joinType) {
Review Comment:
duplicates to JoinType.isSemiOrAntiJoin()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
