morrySnow commented on code in PR #31886:
URL: https://github.com/apache/doris/pull/31886#discussion_r1516035917
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1578,6 +1581,10 @@ public void setEnableLeftZigZag(boolean
enableLeftZigZag) {
"whether to use a materialized view that contains the
foreign table "
+ "when using rewriting based on struct info"})
public boolean materializedViewRewriteEnableContainExternalTable = false;
+ @VariableMgr.VarAttr(name =
MATERIALIZED_VIEW_REWRITE_SUCCESS_CANDIDATE_NUM, needForward = true,
+ description = {"透明改写成功的结果集合，允许参与到CBO候选的最大数量",
Review Comment:
```suggestion
description = {"异步物化视图透明改写成功的结果集合，允许参与到CBO候选的最大数量",
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/MaterializationContext.java:
##########
@@ -150,13 +155,17 @@ public void setSuccess(boolean success) {
/**
* recordFailReason
*/
- public void recordFailReason(ObjectId objectId, Pair<String, String>
summaryAndReason) {
+ public void recordFailReason(StructInfo structInfo, Pair<String, String>
summaryAndReason) {
Review Comment:
maybe use this signature is better
```suggestion
public void recordFailReason(StructInfo structInfo, String summary,
Supplier<String> reasonSupplier) {
...
String reason = enableRecordFailureDetail ? reasonSupplier.get() : ""
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
