github-actions[bot] commented on code in PR #31935:
URL: https://github.com/apache/doris/pull/31935#discussion_r1515769030
##########
be/src/vec/functions/function_struct_in.h:
##########
@@ -116,16 +126,23 @@ class FunctionStructIn : public IFunction {
ColumnPtr column_ptr = std::move(column_struct_ptr_args);
// make StructRef into set
for (size_t i = 1; i < context->get_num_args(); ++i) {
- if (null_in_set && null_map[i - 1]) {
+ if (state->null_in_set && null_map[i - 1]) {
continue;
}
- args_set.insert({column_ptr, i - 1});
+ state->args_set.insert({column_ptr, i - 1});
}
return Status::OK();
}
Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
size_t result, size_t input_rows_count) const override
{
+ auto in_state = reinterpret_cast<StructInState*>(
Review Comment:
warning: 'auto in_state' can be declared as 'auto *in_state'
[readability-qualified-auto]
```suggestion
auto *in_state = reinterpret_cast<StructInState*>(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
