mymeiyi commented on code in PR #31259:
URL: https://github.com/apache/doris/pull/31259#discussion_r1515490073
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -415,12 +416,20 @@ public PlanFragment
visitPhysicalOlapTableSink(PhysicalOlapTableSink<? extends P
slotDesc.setIsNullable(column.isAllowNull());
slotDesc.setAutoInc(column.isAutoInc());
}
- OlapTableSink sink = new OlapTableSink(
+ OlapTableSink sink;
+ // This statement is only used in the group_commit mode in the
http_stream
+ if (context.getConnectContext().isGroupCommitStreamLoadSql()) {
Review Comment:
Here, can we set the session variable `group_commit` in
`FrontendServiceImpl` and use here？
In this way, we does not need add a new variable in ConnectContext
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
