wangshuo128 commented on code in PR #31537:
URL: https://github.com/apache/doris/pull/31537#discussion_r1513881449
##########
gensrc/proto/cloud.proto:
##########
@@ -187,6 +190,25 @@ message ObjectStoreInfoPB {
optional bool sse_enabled = 15;
}
+message StorageVaultPB {
+ optional string id = 1;
+ optional string name = 2;
+ optional HdfsInfo hdfs_infos = 3; // HdfsResource
+}
+
+message HdfsInfo {
+ optional string fs_name = 1;
Review Comment:
We should have a field `path` in `HdfsInfo`, rather then in `hdfs_confs`.
`path` is the place to save data, we should use the `path` value to create
dir or list files. This is one of the arguments of HDFS client methods.
`hdfs_confs` is the configs we create a HDFS client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
