zhannngchen commented on code in PR #31725:
URL: https://github.com/apache/doris/pull/31725#discussion_r1510711448
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -479,7 +486,8 @@ Status
SegmentWriter::append_block_with_partial_content(const vectorized::Block*
std::string error_column;
for (auto cid :
_opts.rowset_ctx->partial_update_info->missing_cids) {
const TabletColumn& col = _tablet_schema->column(cid);
- if (!col.has_default_value() && !col.is_nullable()) {
+ if (!col.has_default_value() && !col.is_nullable() &&
+ !(_tablet_schema->auto_increment_column() ==
col.name())) {
Review Comment:
ditto
##########
be/src/olap/partial_update_info.h:
##########
@@ -32,7 +32,8 @@ struct PartialUpdateInfo {
auto tablet_column = tablet_schema.column(i);
if (!partial_update_input_columns.contains(tablet_column.name())) {
missing_cids.emplace_back(i);
- if (!tablet_column.has_default_value() &&
!tablet_column.is_nullable()) {
+ if (!tablet_column.has_default_value() &&
!tablet_column.is_nullable() &&
+ !(tablet_schema.auto_increment_column() ==
tablet_column.name())) {
Review Comment:
`tablet_column.name() != tablet_schema.auto_increment_column()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
