HappenLee commented on code in PR #31583: URL: https://github.com/apache/doris/pull/31583#discussion_r1509902783
########## be/src/vec/functions/round.h: ########## @@ -222,15 +224,43 @@ class BaseFloatRoundingComputation<Float64> { static VectorType prepare(size_t scale) { return load1(scale); } }; +// for float number use round up or bankers Review Comment: should use the simd version to do the work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org