github-actions[bot] commented on code in PR #31665: URL: https://github.com/apache/doris/pull/31665#discussion_r1509206909
########## be/src/runtime/query_context.h: ########## @@ -148,7 +148,19 @@ class QueryContext { return _shared_scanner_controller; } - vectorized::RuntimePredicate& get_runtime_predicate() { return _runtime_predicate; } + vectorized::RuntimePredicate& get_runtime_predicate(int source_node_id) { Review Comment: warning: method 'get_runtime_predicate' can be made static [readability-convert-member-functions-to-static] ```suggestion static vectorized::RuntimePredicate& get_runtime_predicate(int source_node_id) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org