BiteTheDDDDt commented on code in PR #31669:
URL: https://github.com/apache/doris/pull/31669#discussion_r1508917042
##########
be/src/olap/accept_null_predicate.h:
##########
@@ -116,29 +118,32 @@ class AcceptNullPredicate : public ColumnPredicate {
void evaluate_vec(const vectorized::IColumn& column, uint16_t size,
bool* flags) const override {
- _nested->evaluate_vec(column, size, flags);
if (column.has_null()) {
+ const auto& nullable_col = assert_cast<const
vectorized::ColumnNullable&>(column);
+ _nested->evaluate_vec(nullable_col.get_nested_column(), size,
flags);
for (uint16_t i = 0; i < size; ++i) {
- if (!flags[i] && column.is_null_at(i)) {
+ if (!flags[i] && nullable_col.is_null_at(i)) {
// set true for NULL rows
flags[i] = true;
}
}
+ } else {
+ _nested->evaluate_vec(column, size, flags);
}
}
void evaluate_and_vec(const vectorized::IColumn& column, uint16_t size,
bool* flags) const override {
if (column.has_null()) {
// copy original flags
- auto original_flags_buf = std::make_unique<bool[]>(size);
Review Comment:
better do not change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
