github-actions[bot] commented on code in PR #31650:
URL: https://github.com/apache/doris/pull/31650#discussion_r1508527188
##########
be/src/service/internal_service.cpp:
##########
@@ -748,9 +748,8 @@ void
PInternalService::fetch_arrow_flight_schema(google::protobuf::RpcController
}
}
-Status PInternalServiceImpl::_tablet_fetch_data(const PTabletKeyLookupRequest*
request,
- PTabletKeyLookupResponse*
response) {
- // TODO(yuejing): use PointQueryExecutor lookup_util(_engine); instead
+Status PInternalService::_tablet_fetch_data(const PTabletKeyLookupRequest*
request,
Review Comment:
warning: method '_tablet_fetch_data' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status PInternalService::_tablet_fetch_data(const
PTabletKeyLookupRequest* request,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -761,10 +760,10 @@
return Status::OK();
}
-void PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController*
controller,
- const PTabletKeyLookupRequest*
request,
- PTabletKeyLookupResponse*
response,
- google::protobuf::Closure* done) {
+void PInternalService::tablet_fetch_data(google::protobuf::RpcController*
controller,
Review Comment:
warning: method 'tablet_fetch_data' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
PInternalService::tablet_fetch_data(google::protobuf::RpcController* controller,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
