HappenLee commented on code in PR #30914: URL: https://github.com/apache/doris/pull/30914#discussion_r1506169639
########## be/src/vec/sink/vdata_stream_sender.h: ########## @@ -402,12 +430,20 @@ Status VDataStreamSender::channel_add_rows(RuntimeState* state, Channels& channe int num_channels, const HashValueType* __restrict channel_ids, int rows, Block* block, bool eos) { - std::vector<uint32_t> channel2rows[num_channels]; Review Comment: why change the logic ? use vector to replace array? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org