github-actions[bot] commented on code in PR #31250:
URL: https://github.com/apache/doris/pull/31250#discussion_r1505702732
##########
be/src/runtime/runtime_predicate.cpp:
##########
@@ -26,67 +26,64 @@
#include "olap/column_predicate.h"
#include "olap/predicate_creator.h"
-namespace doris {
+namespace doris::vectorized {
-namespace vectorized {
-
-Status RuntimePredicate::init(const PrimitiveType type, const bool
nulls_first) {
+Status RuntimePredicate::init(PrimitiveType type, bool nulls_first, bool
is_asc,
Review Comment:
warning: function 'init' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status RuntimePredicate::init(PrimitiveType type, bool nulls_first, bool
is_asc,
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/runtime_predicate.cpp:30:** 99 lines including whitespace
and comments (threshold 80)
```cpp
Status RuntimePredicate::init(PrimitiveType type, bool nulls_first, bool
is_asc,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
