github-actions[bot] commented on code in PR #31493:
URL: https://github.com/apache/doris/pull/31493#discussion_r1504217714
##########
be/src/io/fs/hdfs_file_system.cpp:
##########
@@ -121,22 +121,23 @@ Status HdfsFileHandleCache::get_file(const
std::shared_ptr<HdfsFileSystem>& fs,
return Status::OK();
}
-Status HdfsFileSystem::create(const THdfsParams& hdfs_params, const
std::string& fs_name,
- RuntimeProfile* profile,
std::shared_ptr<HdfsFileSystem>* fs) {
+Status HdfsFileSystem::create(const THdfsParams& hdfs_params, std::string id,
Review Comment:
warning: method 'create' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status HdfsFileSystem::create(const THdfsParams& hdfs_params,
std::string id,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
